Enable Source Link and Deterministic Builds #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d renamed output dlls to not conflict
…versions of the assembly
…nt versions for testing, fixed some issues with new level changes
…ded schemabuilder and tagnodeattribute for generating schemas using reflection
…t) to test block loading
Conflicts: Substrate.Tests/LevelTests.cs Substrate.Tests/Substrate.Tests.csproj Substrate.Tests/WorldTests.cs Substrate/Source/Nbt/TagNodeShort.cs Substrate/Substrate.csproj SubstrateCS/Substrate (NET2).csproj SubstrateCS/Substrate.sln
Conflicts: Substrate.Tests/BlockTests.cs Substrate.Tests/LevelTests.cs Substrate.Tests/Properties/AssemblyInfo.cs Substrate.Tests/Substrate.Tests.csproj Substrate.Tests/WorldTests.cs Substrate.sln Substrate/Source/BlockInfo.cs Substrate/Source/Nbt/JSONSerializer.cs Substrate/Source/Nbt/NbtVerifier.cs Substrate/Source/Nbt/TagNodeShort.cs Substrate/Source/Player.cs
Added loading, more removal of backing stores, added event to verifier for unexpected tags
…ctionary as inventory (will probably change)
…et 3.5 binaries from nuget package
Implemented better schema builder list loading
Made options tests fail inconclusive
Improve CLS compliance
Cleanup .csproj / assembly properties
Support more platforms
Use new project format
Convert project to new .NET build
add .NET 5.0 (.NET Core 5)
Use expression to indicate MIT license
|
@jaquadro -- Are you doing any further work on this? |
redwyre
force-pushed
the
2.x
branch
2 times, most recently
from
b3a036d to
7c62ed9
Compare
|
I've made changes to the projects and added sourcelink, as well as uploading a symbol package to nuget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67.
Supercedes PR #65.
Also partial fix for #54 (Enables automated GitHub Actions-based publishing).
I have validated using JustAssembly that the resulting assemblies are equivalent. All built-in tests continue to pass. Just the user experience is improved.
Three things are provided with this PR:
Source Link enables anyone building NuGet libraries to provide source-level debugging for their users with almost no effort. See also documentation.
Used NuGet Package Explorer to verify the package has Source Link enabled and is deterministic
Used JustAssembly with commit 0ce7ce4 to verify assemblies are identical to those published as minecraft-dotnet.Substrate v2.0.44-alpha.